Le dimanche 12 octobre 2008 à 16:54 +0200, Johannes Berg a écrit : > Looks nice, will give it a test later, just a small comment. [...] > > +static struct atp_info fountain_info = { [...] > > +static struct atp_info geyser1_info = { [...] > And there are only three uses. Do we expect to add new uses of the > types, especially different structs that share the type? Otherwise I'd > suggest to use > > if (dev->info == &geyser2_info) and &fountain_info respectively and just > remove the type thing completely. I agree. Updated patch is coming. -- Stelian Pop <stelian@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html