Dmitry Torokhov wrote: > On Tue, Sep 02, 2008 at 10:05:56PM +0200, Henrik Rydberg wrote: >> @@ -296,6 +297,7 @@ static int report_tp_state(struct bcm5974 *dev, int size) >> >> input_report_abs(input, ABS_PRESSURE, int2bound(&c->p, p)); >> >> + input_report_key(input, BTN_TOUCH, p > 0); > > Just relying on p will probably make it too sensitive, have you tried > adding hysteresis, like synaptics driver does? > I have, and the problem is somewhat more complicated when dealing with multiple fingers. The simple patch shown about actually works very well in practice. However, things can always improve. Yesterday I sent a second patch, bcm5974-0.63, which addressed this issue. However, the quality of the mouse movement has regressed a little in that patch. I would like to send yet another patch today, bcm5974-0.64, I hope this does not cause too much confusion. Regarding mousedev, I noticed that the tap functionality does not distinguish between a tap (on/off localized in time and space) and a quick drag (on/off localized in time only). -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
