On Tue, 2008-07-29 at 01:41 -0400, Dmitry Torokhov wrote: > > one thing about the drivers/input/mouse/Kconfig patch: > > > > The original version contained "select USB", which was later changed > > to "depends on USB" by Andrew Morton. I saw it reappear as "select USB" > > in your latest patch, and simply considered it a change back, but > > maybe it was an oversight? > > > > I am of the opinion that it is OK to "select" high-level subsystems that > don't have additional dependencies, especially if they are "past" the > original driver in menuconfig. I don't really like the idea of forcing > users revisiting earlier sub-menus after they selected a new subsystem > to see if there are any new options. Plus, if user wants driver for his > touchpad he does not really care whether it is PS/2 or USB, [s]he just > wants it to work. USB tends to have implicit dependencies like the ehci/ohci/uhci controller though, so it's not going to work like that anyway starting from a minimal config, and all defconfigs probably have USB anyway. Therefore, I personally would keep it as "depends on" rather than "select". YMMV. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
