Re: [PATCH 1/2] Device driver for Atmel integrated touchscreencontroller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

On Tue, Jul 15, 2008 at 12:06:22PM +0200, Liang, Dan wrote:
> Sorry again, the previous [PATCH 1/2] still has some formatting problems.
> 
> Now finally I fixed it.
> 
> The AT91SAM9RL SoC integrates a Touchscreen Controller which can trigger ADC conversion periodically.
> 

Overall looks good, just a couple of comments:

 - The device does not seem to support pressure reading so I will drop
   ABS_PRESSURE reporting.
 - The header file - is it needed? If there are no other users of this
   file expected I will fold it into the driver.

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux