Re: [PATCH] input: push down scancode negative checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-06-30 at 15:47 -0400, Dmitry Torokhov wrote:
> On Mon, Jun 30, 2008 at 12:33:46PM -0700, Daniel Walker wrote:
> > The getkeycode/setkeycode calls should be able to accept "negative" values.
> > 
> > The HID layer has some scan codes of the form 0xffbc0000 for logitech
> > devices, and they get ignored by these calls. I pushed the checking
> > into the input_default_* functions since they do need non-negative
> > values.
> > 
> > I also corrected a typo in the comment for input_set_keycode
> 
> Hmm, I wonder if we just need to type these as unsigned.
> 

I think it would make sense, because AFAIK scancodes don't really have a
concept of signed-ness anyway .. I almost did it that way, but I wasn't
sure enough about the reasoning for the signed int ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux