On Thu, Jun 26, 2008 at 03:32:05PM +0200, Oliver Neukum wrote:
> Hi,
>
> if you kill the URB before you unregister, open can come in between
> and resubmit the urb. This patch reverses the order.
>
> Regards
> Oliver
>
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
>
> ---
>
> --- linux-2.6.26-sierra/drivers/input/touchscreen/usbtouchscreen.c.alt 2008-06-26 15:23:34.000000000 +0200
> +++ linux-2.6.26-sierra/drivers/input/touchscreen/usbtouchscreen.c 2008-06-26 15:23:38.000000000 +0200
> @@ -973,8 +973,8 @@ static void usbtouch_disconnect(struct u
>
> dbg("%s - usbtouch is initialized, cleaning up", __FUNCTION__);
> usb_set_intfdata(intf, NULL);
> - usb_kill_urb(usbtouch->irq);
> input_unregister_device(usbtouch->input);
> + usb_kill_urb(usbtouch->irq);
> usb_free_urb(usbtouch->irq);
> usbtouch_free_buffers(interface_to_usbdev(intf), usbtouch);
> kfree(usbtouch);
I think you can just remove that usb_kill_urb() call since
usbtouch_close() has already called it by that time.
--
Ville Syrjälä
syrjala@xxxxxx
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
