Hi Jiri, The Macbook Pro 4,1 has no numlock key. I am not sure what the HID_QUIRK_APPLE_NUMLOCK_EMULATION flag does. On a somewhat related note, the function key secondary functionality has also changed in the new Macbook Pro/Air models; this requires the "powerbook_fn_keys" lookup table in drivers/hid/hid-input.c to be updated accordingly. The new key layout is detailed here: http://support.apple.com/kb/HT1117 Regards, Alex On Mon, 2008-06-09 at 13:44 +0200, Jiri Kosina wrote: > On Sat, 7 Jun 2008, Matthew Garrett wrote: > > > The keyboards in recent Apple hardware are still not properly supported > > by Linux due to them not being in the hid quirks table. This patch adds > > the current hardware. Device IDs come from the Mactel Linux project. > > Hi Matthew, > > the patch adding these product IDs is already queued in my > 'upstream-fixes' branch. > > However ... > > > + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ANSI, HID_QUIRK_APPLE_NUMLOCK_EMULATION | HID_QUIRK_APPLE_HAS_FN }, > > + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_ISO, HID_QUIRK_APPLE_NUMLOCK_EMULATION | HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_APPLE_ISO_KEYBOARD }, > > + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING_JIS, HID_QUIRK_APPLE_NUMLOCK_EMULATION | HID_QUIRK_APPLE_HAS_FN }, > > + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ANSI, HID_QUIRK_APPLE_NUMLOCK_EMULATION | HID_QUIRK_APPLE_HAS_FN }, > > + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ISO, HID_QUIRK_APPLE_NUMLOCK_EMULATION | HID_QUIRK_APPLE_HAS_FN | HID_QUIRK_APPLE_ISO_KEYBOARD }, > > + { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS, HID_QUIRK_APPLE_NUMLOCK_EMULATION | HID_QUIRK_APPLE_HAS_FN }, > > Alexandre's original patch is missing the > HID_QUIRK_APPLE_NUMLOCK_EMULATION quirk ... Alexandre, was this > intentional? > > Thanks, > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
