On Wed, May 28, 2008 at 05:11:14PM +0200, Antonio Ospite wrote: > On Wed, 28 May 2008 10:31:25 -0400 > Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > > Hi Antonio, > > > > On Wed, May 28, 2008 at 04:25:39PM +0200, Antonio Ospite wrote: > > > > > > - input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) | > > > - BIT_MASK(EV_REL); > > > + input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP); > > > + if (keypad->pdata->rotary0_rel_code || keypad->pdata->rotary1_rel_code) > > > + input_dev->evbit[0] |= BIT_MASK(EV_REL); > > > > Shouldn't this also check pdata->enable_rotaryX? > > > > Yes, maybe. > Do you prefer a check like this? > > if ((keypad->pdata->enable_rotary0 && keypad->pdata->rotary0_rel_code) || > (keypad->pdata->enable_rotary1 && keypad->pdata->rotary1_rel_code)) > input_dev->evbit[0] |= BIT_MASK(EV_REL); > > Just confirm that and I'll resend a fixed version of the patch. > Yep, that should work, thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
