Hello,
> > + /* Setup Clock */
> > + ts->tsc_clk = clk_get(&pdev->dev,"tsc_clk");
> > + if (IS_ERR(ts->tsc_clk)) {
>
> Great, nice to see a driver using the clock API properly.
>
> > + dev_err(&pdev->dev, "unable to get clock\n");
> > + err = PTR_ERR(ts->tsc_clk);
> > + goto err_iounmap;
> > + }
>
> Odd indentation on the last line above.
>
> > + clk_enable(ts->tsc_clk);
To use the clock API properly you should check the return value of
clk_enable, too :-)
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
