hi Justin, > +static u64 atmel_tsadcc_dmamask = 0xffffffffUL; Rather use DMA_BIT_MASK(32). > + /* These values work with a 100 MHz Master Clock for the ADC */ > + .prescaler = 0xC, /* 3.846 MHz Clock */ > + .debounce = 0xE, /* 4.2 ms debounce */ > + .tsshtim = 0x3, /* 1.04 us Sample Hold time */ > + .startup = 0x13, /* 41 us Startup Time */ What is the impact of a different Master Clock rate? This devices.c file is intended to be board-independent. Wouldn't it be better for the driver to call clk_get_rate() and calculate "good" values for these? > + .coherent_dma_mask = 0xffffffff, Similarly, DMA_BIT_MASK(32). Regards, Andrew Victor -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
