From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Build fixes: drivers/input/keyboard/omap-keypad.c: In function 'omap_kp_probe': drivers/input/keyboard/omap-keypad.c:418: warning: 'row_idx' is used uninitialized in this function drivers/input/keyboard/omap-keypad.c:421: warning: 'col_idx' is used uninitialized in this function These variables are useful when cpu_is_omap24xx(), and otherwise just for useless cleanup. Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> --- This has been in the OMAP tree since 24-Feb. drivers/input/keyboard/omap-keypad.c | 3 +++ 1 files changed, 3 insertions(+) --- a/drivers/input/keyboard/omap-keypad.c 2008-02-24 18:50:32.000000000 -0800 +++ b/drivers/input/keyboard/omap-keypad.c 2008-02-24 19:10:17.000000000 -0800 @@ -352,6 +352,9 @@ static int __init omap_kp_probe(struct p } omap_set_gpio_direction(row_gpios[row_idx], 1); } + } else { + col_idx = 0; + row_idx = 0; } setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp); -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html