[patch]unnecessary GFP_ATOMIC in xpad driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



GFP_ATOMIC should not be used when GFP_KERNEL can be used.

Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>

---

--- linux-2.6.25-rc7-work/drivers/input/joystick/xpad.c.2	2008-04-03 13:29:55.000000000 +0200
+++ linux-2.6.25-rc7-work/drivers/input/joystick/xpad.c	2008-04-03 13:30:01.000000000 +0200
@@ -412,7 +412,7 @@ static int xpad_init_output(struct usb_i
 		return 0;
 
 	xpad->odata = usb_buffer_alloc(xpad->udev, XPAD_PKT_LEN,
-				       GFP_ATOMIC, &xpad->odata_dma );
+				       GFP_KERNEL, &xpad->odata_dma );
 	if (!xpad->odata)
 		goto fail1;
 
@@ -636,7 +636,7 @@ static int xpad_probe(struct usb_interfa
 		goto fail1;
 
 	xpad->idata = usb_buffer_alloc(udev, XPAD_PKT_LEN,
-				       GFP_ATOMIC, &xpad->idata_dma);
+				       GFP_KERNEL, &xpad->idata_dma);
 	if (!xpad->idata)
 		goto fail1;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux