Re: [patch 01/23] fjkeyinf driver for FSC Lifebook laptops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zitat von Jiri Kosina <jkosina@xxxxxxx>:
On Mon, 10 Mar 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
From: Hendrik Sattler <post@xxxxxxxxxxxxxxxxxx>
This is another approach for FJKEYINF support for the FSC Lifebook laptop
series.  In comparison to the apanel driver that was posted lately, it
supports more than one entry in the table and slits off the actual handling of
the I2C devices to seperate drivers, allowing resuse in other scenarios.

s/resuse/reuse, right?

Right.

Also, is there any effort to merge this with Stephen's apanel driver? Or
what is the advantage of having these two drivers separately?

Cleaner.
The original author of apanel did (in anothere approach for BSD) actually the same. He was also my source for OZ990 documentation. The apanel driver does mix several devices into one driver. Even though it doesn't work for my laptop, I see to gain in hacking more into it if it can be done in a better way. The current I2C framework makes a separation easy enough. Additionally, the OZ99x driver checks that there actually is such a chip at that I2C address.

Note that those are normal I2C chips used, thus generic drivers for them can be reused somewhere else. Again, this is not possible with the apanel driver.

This is not a full replacement for apanel, though, as it addresses not the same hardware (different laptops). I asked Stephen to show me his fjkeyinf data but he did not respond to my mail.

HS


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux