On Sat, Feb 16, 2008 at 04:22:43PM +0000, Peter Stokes wrote: > The attached patch reconfigures the ati_remote2 driver to use soft-autorepeat > functionality and adds support for loadable key maps. Why was this submitted (and even accepted) without cc:ing me? > I have reconfigure the driver to use the input system's built-in autorepeat > functionality as the device only appears to be able to produce key repeat > notifications at a fixed period. Switching to the software autorepeat > functionality provides more precise configuration of the timings requested > for repeat-delay and repeat-rate. The soft-autorepeat support should be split into a separate patch. I don't need such fast repeat but if it helps people I'm fine with it. > As this device is exposed as a combined keyboard and mouse, this change > somewhat depends upon the suggested modification to the core soft-autorepeat > functionality as outlined in my previous post to the linux-input mailing list > (on 12th Feb 2008 entitled "Soft-autorepeat functionality"), without that > modification, the mouse buttons are autorepeated :-( > > The loadable keymap support exposes the ability to map 5 separate keycodes to > each key (depending on which "mode" the remote control is currently in). > Additionally, I have attempted to ensure that the scancodes used to map > keycodes to the keys lie outside of the range normally covered by regular > keyboards so as to avoid requests to remap the keys on the remote from being > intercepted by a normal keyboard. I thought the idea of input devices was to reflect the hardware and the keymaps should be handled in userspace. If that's not the case then I think the keymap support code should not be inside the driver but instead inside the input core. We don't want such invasive changes in every driver do we? -- Ville Syrjälä syrjala@xxxxxx http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
