On Mon, 03 Mar 2008 23:55:57 +0100
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> On 03/03/2008 11:30 PM, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > Subject: input: add debouncing for generic gpio input device gpio_key.c
> > From: Keith Mok <ek9852@xxxxxxxxx>
> >
> > Add debouncing support for the generic gpio input device, since debouncing is
> > most likely to happen.
> >
> > Signed-off-by: Keith Mok <ek9852@xxxxxxxxx>
> > Cc: Herbert Valerio Riedel <hvr@xxxxxxx>
> > Cc: Dmitry Torokhov <dtor@xxxxxxx>
> > Cc: Jiri Slaby <jirislaby@xxxxxxxxx>
> > Cc: Anti Sullin <anti.sullin@xxxxxxxxxxxxxx>
> > Cc: David Brownell <david-b@xxxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > drivers/input/keyboard/gpio_keys.c | 106 +++++++++++++++++++++++----
> > 1 file changed, 93 insertions(+), 13 deletions(-)
> >
> > diff -puN drivers/input/keyboard/gpio_keys.c~input-add-debouncing-for-generic-gpio-input-device-gpio_keyc drivers/input/keyboard/gpio_keys.c
> > --- a/drivers/input/keyboard/gpio_keys.c~input-add-debouncing-for-generic-gpio-input-device-gpio_keyc
> > +++ a/drivers/input/keyboard/gpio_keys.c
> [...]
> > static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
> [...]
> > + /* disable keyboard interrupt and schedule for handling */
> > + for (i = 0; i < pdata->nbuttons; i++) {
> > + int irq = gpio_to_irq(pdata->buttons[i].gpio);
> > + disable_irq(irq);
>
> Are you 100% sure here (are you disabling irqs other than this one)? No
> disable_irq_nosync? Anyway why is the disabling needed at all?
>
lol, I cc'ed the wrong Jiri and it worked out well.
Please do cc the appropriate mailing list when replying to -mm commit
emails.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
