On Fri, 29 Feb 2008 19:48:56 +0900 Magnus Damm <magnus.damm@xxxxxxxxx> wrote: > This patch adds a platform driver for the SuperH KEYSC block. The driver > expects to get mode, timing information and keypad layout from the board > code as platform data. The board code is resonsible for pin configuration. > > Both sh7343 and sh7722 should be supported, but only the sh7722 processor > has been tested so far. SH_KEYSC_MODE_3 is yet to be tested. > > ... > > +#define res_size(res) ((res)->end - (res)->start + 1) - buggy macro references its argument more than once - could be implemented in C - perhaps should be implemented in <linux/ioport.h> > + input->phys = "sh-keysc-keys/input0"; Is the "/" in here safe? I trust we don't try to create a sysfs/procfs/whatever file based off this string. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
