Hi, On Mon, 11 Feb 2008 12:04:42 -0500 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Mon, Feb 11, 2008 at 11:00:27AM -0500, Dmitry Torokhov wrote: > > Hi Yoichi, > > > > On Mon, Feb 11, 2008 at 09:54:04PM +0900, Yoichi Yuasa wrote: > > > Fix cobalt_btns loadable keymaps support. > > > > > > > Thank you for the patch. > > > > > input_set_capability(input, EV_MSC, MSC_SCAN); > > > __set_bit(EV_KEY, input->evbit); > > > - for (i = 0; i < ARRAY_SIZE(buttons_map); i++) > > > - __set_bit(input->keycode[i], input->keybit); > > > + for (i = 0; i < ARRAY_SIZE(cobalt_map); i++) > > > + __set_bit(bdev->keymap[i], input->keybit); > > > > This part is not strictly necessary since input->keycode points to > > bdev->keymap. I will apply the rest of the patch. > > > > Oh, I see now... The controlling condition is the loop was incorrect. Exactly yes. Thanks, Yoichi - To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html