Re: [PATCH 1/12] pxa: rename the pxa27x_keyboard to pxa27x_keypad

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 29 January 2008 01:57, eric miao wrote:
> On Jan 29, 2008 2:26 PM, Dmitry Torokhov <dtor@xxxxxxxxxxxxx> wrote:
> > Hi Eric,
> >
> > On Wednesday 23 January 2008 02:16, eric miao wrote:
> > > Subject: [PATCH] pxa: rename the pxa27x_keyboard to pxa27x_keypad
> > >
> > > The controller should really be called keypad, and also align
> > > the naming of functions and structures to use "pxa27x_keypad"
> > > as prefix, instead of "pxakbd".
> >
> > Not sure what the difference is... Seems to be a gratuous renaming.
> >
> 
> Yeah, though I used git-mv, the result of git-format-patch still looks horrible.

Probably if you do move commit and rename separately it will be somewhat cleaner.

> Anyway, this is just a naming issue. While other pxa drivers are slowly
> transitioning to a more standard naming convention (if you take a look at
> recent [arch/arm/mach-pxa/devices.c] in Linus's recent tree) I first update
> this to later patches could be more specific.

Let me take a look...

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux