In hidinput_configure_usage(device), IS_CHICONY_TACTICAL_PAD(devic) gets passed the 'device' parameter. But that macro still references its parameter by 'device' instead of by its local name 'x'. Signed-off-by: Philipp Matthias Hahn <pmhahn@xxxxxxxxxxxxx> --- linux/drivers/hid/hid-input.c 2008-01-25 09:57:17.000000000 +0100 +++ linux/drivers/hid/hid-input.c 2008-01-25 10:56:35.835871529 +0100 @@ -87,7 +87,7 @@ #define map_key_clear(c) do { map_key(c); clear_bit(c, bit); } while (0) /* hardware needing special handling due to colliding MSVENDOR page usages */ -#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && device->product == 0x0418) +#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && x->product == 0x0418) #define IS_MS_KB(x) (x->vendor == 0x045e && (x->product == 0x00db || x->product == 0x00f9)) #ifdef CONFIG_USB_HIDINPUT_POWERBOOK -- / / (_)__ __ ____ __ Philipp Hahn / /__/ / _ \/ // /\ \/ / /____/_/_//_/\_,_/ /_/\_\ pmhahn@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html