Hi Carlos,
On Sat, Jan 12, 2008 at 01:22:38AM +0000, Carlos Corbacho wrote:
>
> Can you please check the i8042_command() call is correct, I'm having
> trouble getting my head around the call semantics. What I'm trying to do
> is send the command 0x59 with one argument, 0x90.
>
Yep, this should work.
> +static unsigned int i8042_dritek = 0;
> +module_param_named(dritek, i8042_dritek, bool, 0);
> +MODULE_PARM_DESC(dritek, "Force enable the Dritek keyboard extension");
I think this should be wrapped in CONFIG_X86. Also it does not make sense
to 0-initialize static variables.
> @@ -1171,6 +1176,13 @@ static int __devinit i8042_probe(struct platform_device *dev)
> */
> i8042_register_ports();
>
> + if (i8042_dritek) {
> + param = 0x90;
> + error = i8042_command(¶m, 0x1059);
> + if (error)
> + goto out_fail;
> + }
> +
I think this call should be moved above i8042_register_ports() so atkbd
will have i8042 fully setup before pribing.
Let me know if you agree, I have the above fixedon my side. Thanks!
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
