Hi, On Jan 3, 2008 6:01 PM, Dmitry Baryshkov <dbaryshkov@xxxxxxxxx> wrote: > > > > > Also, I'd put these defines rigth in tosakbd.c. > > The TOSA_KEY_RECORD and SYNC are used inside arch/arm/mach-pxa/tosa.c > (for gpio-keys declaration). So I would prefer to place all such defines here. > When the Kdrive would be fixed, I would drop KEY_RECORD and happily move > that defines to tosakbd.c > Ok, fair enough. Because driver touches arch-specific arm parts it does not apply cleanly to my tree. I think the best way would be to merge it through arm side, this will minimize merge efforts Feel free to add: Acked-by: Dmitry Torokhov <dtor@xxxxxxx> -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
