Re: [PATCH] Require all interfaces to be up before using iscsistart -b

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15.06.2015 11:51, Harald Hoyer wrote:
> On 15.06.2015 11:34, Ross Lagerwall wrote:
>> ping!
>>
>> On 05/14/2015 09:30 AM, Ross Lagerwall wrote:
>>> If multiple targets are specified in the ibft, iscsistart will log into
>>> all of them, possibly using multiple interfaces. Since iscsistart is run
>>> indirectly from ifup, require that all interfaces are up before actually
>>> logging into the targets.
>>> ---
>>>   modules.d/95iscsi/iscsiroot.sh |    5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/modules.d/95iscsi/iscsiroot.sh b/modules.d/95iscsi/iscsiroot.sh
>>> index 1de6fb7..b9e99cb 100755
>>> --- a/modules.d/95iscsi/iscsiroot.sh
>>> +++ b/modules.d/95iscsi/iscsiroot.sh
>>> @@ -45,6 +45,11 @@ fi
>>>
>>>   handle_firmware()
>>>   {
>>> +    # iscsistart -b may use multiple interfaces so only run when
>>> +    # all are ready.
>>> +    type all_ifaces_up >/dev/null 2>&1 || . /lib/net-lib.sh
>>> +    all_ifaces_up || return 1
>>> +
>>>       if ! [ -e /tmp/iscsistarted-firmware ]; then
>>>           if ! iscsistart -f; then
>>>               warn "iscistart: Could not get list of targets from firmware."
>>>
> 
> 
> I would love to do that, but users want to have "iscsistart -b" executed
> regardless of faulty network configuration of interfaces, which are not part of
> the critical path for root mounting.
> 
> So, if you add a "iscsistart -b" in the timeout hook (which is removed, if once
> succeeded in the normal path), then I guess it will be fine for all.
> 

Oh, and ideally I want to see systemd units for iscsistart, or move to iscsid
completely.

And iscsid/iscistart would just handle all netlink events.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux