Re: [Patch v2] network: add static route support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/27/14 at 01:24pm, Harald Hoyer wrote:
> On 27.06.2014 12:33, Baoquan He wrote:> On 06/27/14 at 10:57am, Harald Hoyer wrote:
> >>
> >> "_" or ":" as a seperator??? code and documentation seem to differ
> >
> > Sorry, I tried to keep consitent with other parameter which use
> > semicolon as separator when add parameter description, then I realized
> > what you suggested using underscore is more meaningful because of ipv6.
> > So here forgot changing the example.
> >
> >>
> >> Can we restrict this to network gateway dev ?
> >
> > I think it cann't be. This special case is raised by Marc, the scenario
> > is in kdump kernel below 3 services need be done and go through
> > different NIC. Though default gateway is setup for one NIC, other
> > service need route to direct.
> >
> > 1)NFS or SSH or iscsi host
> > 2)cluster heartbeat host
> > 3)DNS resolver
> 
> huh? Isn't a network with mask 32 a host route. So, I think network/gateway/dev
> should be enough.
> 
> rd.route=192.168.100.222/32_192.168.1.1_ens10

This is the test environment for this patch. Default gateway goes
through eth0, while the kdump target (192.168.200.222) goes through
ens10. These 2 NICs are not in the same subnet. For guiding data path, as
you said, network/gateway/dev is truly enough. 

default via 192.168.122.1 dev eth0  proto static  metric 1024 
192.168.200.0/24 via 192.168.100.222 dev ens10  proto static  metric 1

> 
> >
> >>
> >> On 27.06.2014 10:08, Baoquan He wrote:
> >>> User may specify static route for a target address which is different
> >>> than default gateway, hence static route need be added.
> >>>
> >>> Now add a cmdline parameter rd.route="" and the related operation to
> >>> parse it. User can add static route by specify it in cmdline like:
> >>>
> >>> rd.route="192.168.200.0/24:via:192.168.100.222:dev:ens10"
> >
> > Here should be:
> >
> > rd.route="192.168.200.0/24_via_192.168.100.222_dev_ens10"
> >
> 
> 
> in theory we could also use ":" and for IPv6 require [] to be consistent.
> 
> rd.route=192.168.100.222/32:192.168.1.1:ens10
> rd.route=[2001:DB7::]:[2001:DB8::1]:ens10
Ah, yeah, this works. 

But using "_" as you suggested before is much easier, code is very
simple and understandable.


> 
> 
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux