On 05/29/14 at 02:27pm, Dave Young wrote:
> On 05/05/14 at 03:12pm, Baoquan He wrote:
> > User may specify static route for a target address which is different
> > than default gateway. The static route file could be like below:
> >
> > 192.168.200.222 via 192.168.100.222 dev eth0
> >
> > Or
> >
> > ADDRESS0=192.168.200.0
> > NETMASK0=255.255.255.0
> > GATEWAY0=192.168.100.222
>
> For the latter format ADDRESS0, I guess the '0' means the order number of nic.
> But if it's renamed to anything else which is not ending with number how to
> find the right card?
>
> So how about use one uniform format like "192.168.200.222 via 192.168.100.222 dev eth0"?
>
> Maybe always get the route item by 'ip' command instead of reading the route file?
> Using ip command there's another possible advantage that no need to handle ipv6 specific
> formats in route file if there's any different.
I guess ADDRESS0 means in one route-$netif file, there could be several
ip address on this $netif and several related routes. And according to
the code annatation in /etc/sysconfig/network-scripts/ifup-routes, this
is the new format of route file. Adding this can support the generic
route cases if other users want to add route, not only kdump.
I am OK if only take the older format, it's sufficient for kdump use.
>
> >
> > In this patch, port the static route hanling from ifup-routes of initscript
> > component.
> >
> > v1->v2:
> > Remove the commentary line checking code and "MATCH" pattern
> > definition since dracut require posix syntax. Let's focus on the
> > functionality of static route.
> >
> > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
> > ---
> > modules.d/40network/net-lib.sh | 39 +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> >
> > diff --git a/modules.d/40network/net-lib.sh b/modules.d/40network/net-lib.sh
> > index a82f1a8..0d488b5 100755
> > --- a/modules.d/40network/net-lib.sh
> > +++ b/modules.d/40network/net-lib.sh
> > @@ -103,6 +103,16 @@ setup_net() {
> > [ -e /tmp/net.$netif.resolv.conf ] && \
> > cp -f /tmp/net.$netif.resolv.conf /etc/resolv.conf
> >
> > + #add static route if exist
> > + f="/etc/route-$netif"
> > + if [ -e "$f" ]; then
> > + if grep -Eq '^[[:space:]]*ADDRESS[0-9]+=' $f ; then
> > + handle_file $f $netif
> > + else
> > + handle_ip_file $f
> > + fi
> > + fi
> > +
>
> Suppose it's for static setup only, how about moving the code into do_static
> in ifup.sh
I am fine with this, but I tend to handle it in setup_net.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
