Re: [PATCH 1/2 v2] ismounted fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.09.2012 15:59, schrieb Vivek Goyal:
> On Mon, Sep 17, 2012 at 06:01:03PM +0800, Dave Young wrote:
>>
>> ismounted handles both find-by-dev and find-by-mnt, but there's two issues:
>> 1. for find-by-dev, it use readlink to get the canonical dev name, but
>>    lvm is different with other devices, the canonical name for lvm devices
>>    are symlinks like /dev/mapper/vg-lv00
>> 2. for nfs mounting, just use [ -b $dev ] is not enough, it need being handled
>>    seperately.
>>
>> Per Karel Zak's suggestion, findmnt util is suitable for this purpose, it
>> handles these cases well, so just use findmnt instead of implement all the
>> logic by ourselves. Thanks, Karel.
> 
> This patch looks reasonable to me. Harald, are you fine with it?
> 
> Vivek

Yes. Looks good!

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux