Re: [PATCH] dracut: use TMPDIR defintion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 16.05.2011 17:46, schrieb maximilian attems:
> mktemp has marked the "-t" as deprecated.
> TMPDIR is anyway write guarded just a line above since dracut 003.
> 
> Signed-off-by: maximilian attems <max@xxxxxxx>
> ---
>  dracut |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/dracut b/dracut
> index d19c162..e018061 100755
> --- a/dracut
> +++ b/dracut
> @@ -452,7 +452,7 @@ elif [[ -f "$outfile" && ! -w "$outfile" ]]; then
>  fi
>  
>  [[ $TMPDIR && ! -w $TMPDIR ]] && unset TMPDIR

We should even remove the above line, because we really want /var/tmp here.
/tmp might be to small and we want to prevent accidents (like as we do, when we
set $PATH)

> -readonly initdir=$(mktemp --tmpdir=/var/tmp/ -d -t initramfs.XXXXXX)
> +readonly initdir=$(mktemp --tmpdir=${TMPDIR:-/var/tmp/} -d initramfs.XXXXXX)
>  
>  # clean up after ourselves no matter how we die.
>  trap 'ret=$?;rm -rf "$initdir";exit $ret;' EXIT

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux