Re: [PATCH 6/9] 40network: install dhclient, brctl and ifenslave optionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/25/2011 03:56 PM, Amadeusz Żołnowski wrote:
Warning given by check() function in case if any of those binaries
doesn't exist was removed, because it's produces by "dracut_install -o"
later.

I'll have to object to this, sorry. The current network implementation does not check if these binaries are there and throws errors if ip=dhcp is provided and no dhclient is available.

---
  modules.d/40network/module-setup.sh |    9 ++-------
  1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/modules.d/40network/module-setup.sh b/modules.d/40network/module-setup.sh
index 59f358f..f32745c 100755
--- a/modules.d/40network/module-setup.sh
+++ b/modules.d/40network/module-setup.sh
@@ -11,12 +11,6 @@ check() {
              return 1
          fi
      done
-    for program in dhclient brctl ifenslave tr; do
-        if ! type -P $program>/dev/null; then
-            dwarn "Could not find program \"$program\" it might be required " \
-                "by network."
-        fi
-    done

      return 255
  }
@@ -48,7 +42,8 @@ installkernel() {
  }

  install() {
-    dracut_install ip dhclient brctl arping ifenslave tr
+    dracut_install ip arping tr
+    dracut_install -o dhclient brctl ifenslave
      inst "$moddir/ifup" "/sbin/ifup"
      inst "$moddir/netroot" "/sbin/netroot"
      inst "$moddir/dhclient-script" "/sbin/dhclient-script"
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux