Re: [PATCH 01/16] Trivial cleanups in dracut-functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




"Luca Berra" <bluca@xxxxxxxxxx> wrote:

>On Sat, Aug 14, 2010 at 02:23:24PM -0500, Victor Lowther wrote:
>>-    if [[ -f "/sys/dev/block/$2/../dev" ]]; then
>>+    if [[ -f /sys/dev/block/$2/../dev ]]; then
>
>I fail to see any advantages in removing quotes from patterns,
>on the contrary i think it could lead to weird failures.
>
>if it were me i'd add quotes where they are missing instead.

No need to in bash when testing conditions inside [[ ]]. Word splitting and path expansion are not performed,  because [[ ]] is syntax, not a built-in command. 

>L.
>
>-- 
>Luca Berra -- bluca@xxxxxxxxxx
>         Communication Media & Services S.r.l.
>  /"\
>  \ /     ASCII RIBBON CAMPAIGN
>   X        AGAINST HTML MAIL
>  / \
>--
>To unsubscribe from this list: send the line "unsubscribe initramfs" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sent from my Nexus One with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux