On 11/23/2009 03:44 PM, Pawel Krzesniak wrote:
Victor Lowther<victor.lowther@...> writes:
On Sep 3, 2009, at 1:33 AM, Joe Pelkey<pelkeyj@...> wrote:
Hi,
I was randomly looking through the git repository and came across
modules.d/95resume/resume.sh and its comment about not liking the
use of
ls. I modified it to use stat instead, and since stat has been in
coreutils since at least late 2005, I assume it's safe to use.
<snip patch>
We had a patch that did that initally, but dropped it because it adds
another binary to the initramfs.
What else depends on 'ls'?
I can see 'ls' is used only in modules.d/95nfs/install which is invoked during
creating initramfs image only. Am I wrong?
btw: Joe's patch has bug, because stat returns major and minor in hex and we
need decimal values. We can use printf (which is part of dash) to convert values.
my version:
Subject: [PATCH] use stat binary instead of ls
Signed-off-by: Pawel Krzesniak<pawel.krzesniak@xxxxxxxxx>
---
modules.d/95resume/install | 1 +
modules.d/95resume/resume.sh | 7 +++----
modules.d/99base/install | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/modules.d/95resume/install b/modules.d/95resume/install
Hmm, having "ls" in the rescue shell is better than "stat"
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
