Re: [PATCH 02/10] output everything to /dev/kmesg and add dmesg for the emergency_shell

[Harald Hoyer <harald@xxxxxxxxxx>]

Am 03.07.2009 20:11, schrieb David Dillow:
> On Fri, 2009-07-03 at 18:45 +0200, Harald Hoyer wrote:
>
> > diff --git a/modules.d/99base/init b/modules.d/99base/init
> > index 701706d..b49ba21 100755
> > --- a/modules.d/99base/init
> > +++ b/modules.d/99base/init
> > @@ -7,6 +7,8 @@
> >
> >   emergency_shell()
> >   {
> > +    exec>/dev/console 2>&1</dev/console
> > +    getarg rdinitdebug || dmesg
>
> Ugh, please no. If I want dmesg output in my emergency shell, I can type
> 'dmesg'. Doing it for me means I may push valuable information from
> rdinitdebug out of my scrollback buffer before I've had a chance to
> review it and write it down.

ok

> Also, this adds a dependency on dmesg to a stripped down install, which
> is counter to (my) goal of a smaller initramfs over time.
>
> > -getarg rdinitdebug&&  set -x
> > +if getarg rdinitdebug; then
> > +    set -x
> > +else
> > +    exec>/dev/kmsg 2>&1
> > +fi
>
> I'm really not happy about polluting the kernel message source with
> dracut messages. I know it is convenient, but in my opinion, dmesg
> should only show me kernel messages, not a mixture of kernel and
> userspace.
>
> At the very least, we need to add an indication that the message is from
> dracut, not the kernel.

hmm, ok

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature