Re: [RFC PATCH 1/5] Add "die" and some minor changes in base

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Don't have time for a full review at the moment, but this jumped out at
me:

On Fri, 2009-06-12 at 17:11 +0200, Seewer Philippe wrote:
> ---
>  modules.d/99base/dracut-lib         |    6 ++++++
>  modules.d/99base/init               |   14 +++-----------
>  modules.d/99base/parse-root-opts.sh |    1 -
>  3 files changed, 9 insertions(+), 12 deletions(-)
> 
> diff --git a/modules.d/99base/dracut-lib b/modules.d/99base/dracut-lib

> +die() {
> +    printf "FATAL: $1\n"
> +    printf "Refusing to continue\n"
> +    exit 1
> +}
> +

> --- a/modules.d/99base/init
> +++ b/modules.d/99base/init

> +[ -z "$root" ] && die "No or empty root= argument"
> +[ -z "$rootok" ] && die "Don't know how to handle 'root=$root'"

If you call die, you don't get an emergency shell. Not very friendly...
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux