On Wed, 22 Jan 2025 06:14:19 +0000 Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote: > On Tue, Jan 21, 2025 at 03:20:07PM -0800, Gwendal Grignou wrote: > > For debugging, add tracing for EC_CMD_MOTION_SENSE_CMD command: > > - decode the name of the subcommand > > - provide internal information for the most common sub-commands: > > setting range, frequency, EC probing frequency, ... > > - display return status. > > > > When enabled, the tracing output is similar to: > > /sys/kernel/debug/tracing # echo 1 > events/cros_ec/enable ; echo 1 > tracing_on ; cat trace_pipe | grep MOTIONSENSE_CMD_SENSOR_ODR > > SensorDeviceImp-814 [003] ..... 686.176782: cros_ec_motion_host_cmd: MOTIONSENSE_CMD_SENSOR_ODR, id: 1, data: 200000, result: 4, return: 12500 > > > > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > > Except I can't verify the build error seen in v3, the patch looks good to me, > Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> > > > --- > > Changes from v2 (https://patchwork.kernel.org/patch/13944028/): > > - Fix include error, based on commit a98c75fcd0e ("drm/tegra: trace: Fix path to include") > > Typo, v3. Applied thanks. I'll be rebasing on rc1 once available. Until then only pushed out as testing.
