On Sat, 18 Jan 2025 18:25, David Lechner <dlechner@xxxxxxxxxxxx> wrote: >On 1/16/25 9:01 AM, Guillaume Ranquet wrote: >> Some chips of the ad7173 family supports open wire detection. >> >> Generate a level fault event whenever an external source is disconnected >> from the system input on single conversions. >> >> Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx> >> --- > >... > >> @@ -1375,6 +1523,7 @@ static int ad7173_fw_parse_channel_config(struct iio_dev *indio_dev) >> chan_st_priv->cfg.bipolar = false; >> chan_st_priv->cfg.input_buf = st->info->has_input_buf; >> chan_st_priv->cfg.ref_sel = AD7173_SETUP_REF_SEL_INT_REF; >> + chan_st_priv->cfg.openwire_comp_chan = -1; > > ^ > >> st->adc_mode |= AD7173_ADC_MODE_REF_EN; >> if (st->info->data_reg_only_16bit) >> chan_arr[chan_index].scan_type = ad4113_scan_type; >> @@ -1442,6 +1591,7 @@ static int ad7173_fw_parse_channel_config(struct iio_dev *indio_dev) >> chan_st_priv->chan_reg = chan_index; >> chan_st_priv->cfg.input_buf = st->info->has_input_buf; >> chan_st_priv->cfg.odr = 0; >> + chan_st_priv->cfg.openwire_comp_chan = -1; > > ^ > >Looks like the same line added twice in the same function. Indeed, but the first one is for the temperature channel which the parse_channel_config function handles separately than the rests of the input that are into the `device_for_each_child_node_scoped()` Thx, Guillaume. > >> >> chan_st_priv->cfg.bipolar = fwnode_property_read_bool(child, "bipolar"); >> if (chan_st_priv->cfg.bipolar)
