The rpr0521_trigger_consumer_handler() is registered as the trigger
threaded handler in the devm_iio_triggered_buffer_setup() function.
This function is being called in 2 ways:
a) when there is a registered trigger being trigger like sysfs or hrt.
The call of the trigger handler (which is the iio_pollfunc_store_time())
follows which saves the timestamp and then, wakes up the trigger
threaded handler.
b) The irq handler is using the iio_trigger_poll_nested() which wakes
up the trigger threaded handler.
In both cases, the pf->timestamp has already been assigned a value
so there is no need to check if it is 0, neither to 0 it after
the push to the buffer.
Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>
---
drivers/iio/light/rpr0521.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c
index 56f5fbbf79ac..ae6a22b91b8d 100644
--- a/drivers/iio/light/rpr0521.c
+++ b/drivers/iio/light/rpr0521.c
@@ -446,13 +446,8 @@ static irqreturn_t rpr0521_trigger_consumer_handler(int irq, void *p)
int err;
/* Use irq timestamp when reasonable. */
- if (iio_trigger_using_own(indio_dev) && data->irq_timestamp) {
+ if (iio_trigger_using_own(indio_dev))
pf->timestamp = data->irq_timestamp;
- data->irq_timestamp = 0;
- }
- /* Other chained trigger polls get timestamp only here. */
- if (!pf->timestamp)
- pf->timestamp = iio_get_time_ns(indio_dev);
err = regmap_bulk_read(data->regmap, RPR0521_REG_PXS_DATA,
data->scan.channels,
@@ -463,7 +458,6 @@ static irqreturn_t rpr0521_trigger_consumer_handler(int irq, void *p)
else
dev_err(&data->client->dev,
"Trigger consumer can't read from sensor.\n");
- pf->timestamp = 0;
iio_trigger_notify_done(indio_dev->trig);
--
2.25.1
