On Mon, Dec 11, 2023 at 06:09:44PM +0100, Fabrice Gasnier wrote: > On 12/11/23 16:59, William Breathitt Gray wrote: > > On Wed, Dec 06, 2023 at 05:47:26PM +0100, Fabrice Gasnier wrote: > >> Add MAINTAINERS entry for the counter watch events tool. William has > >> been asking to add at least me as the point of contact for this utility. > >> > >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx> > >> --- > >> Changes in v3: Add MAINTAINERS entry. This is a split of another patch > >> series[1]. > >> [1] https://lore.kernel.org/lkml/20230922143920.3144249-1-fabrice.gasnier@xxxxxxxxxxx/ > >> --- > >> MAINTAINERS | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index dd5de540ec0b..b8541ab7866a 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -5322,6 +5322,11 @@ F: include/linux/counter.h > >> F: include/uapi/linux/counter.h > >> F: tools/counter/ > >> > >> +COUNTER WATCH EVENTS TOOL > >> +M: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx> > >> +S: Maintained > >> +F: tools/counter/counter_watch_events.c > > > > Add an L line as well for the linux-iio@xxxxxxxxxxxxxxx address so > > discussions get sent to our public mailing list. > > Hi William, > > I can add it, yes. But just to be sure, with current patch, > get_maintainer.pl gives me: > > ./scripts/get_maintainer.pl tools/counter/counter_watch_events.c > Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx> (maintainer:COUNTER WATCH > EVENTS TOOL) > William Breathitt Gray <william.gray@xxxxxxxxxx> (maintainer:COUNTER > SUBSYSTEM) > linux-iio@xxxxxxxxxxxxxxx (open list:COUNTER SUBSYSTEM) > linux-kernel@xxxxxxxxxxxxxxx (open list) > > So is it really needed to add an L line ? > > Best Regards, > Fabrice I think the get_maintainer.pl script tries its best to find a list when one isn't specified, so when it doesn't find a list under the COUNTER WATCH EVENTS TOOL entry, it finds the "tools/counter" directory specified under the COUNTER SUBSYSTEM entry and pulls in that list. Although we end up with the same list, that level of indirection makes it somewhat ambiguous to a user whether that's the correct list to mail. So just to be proper and clear, we should provide an explicit L line so there is no confusion. William Breathitt Gray
Attachment:
signature.asc
Description: PGP signature
