On Tue, 14 Nov 2023 21:29:58 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 14/11/2023 21:05, Alisa-Dariana Roman wrote: > > Document properties used for clock configuration. > > Some background here is missing - otherwise it looks like you are adding > new properties... > > > > > Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx> > > --- > > .../devicetree/bindings/iio/adc/adi,ad7192.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > index 16def2985ab4..9b59d6eea368 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > @@ -80,6 +80,16 @@ properties: > > and when chop is disabled. > > type: boolean > > > > + adi,clock-xtal: > > + description: | > > + External crystal connected from MCLK1 to MCLK2. > > And this should be input clock. Fair enough. We've been doing this wrong for a while then, but good not to do it in new bindings. It's a bit of an oddity as arguably it's just putting an analog component in as part of an internally generated clock signal. A clock binding provides info that the crystal is present though I guess, even though if you actually connected a conventional clock there it wouldn't work. > > > + type: boolean > > + > > + adi,int-clock-output-enable: > > + description: | > > + Internal 4.92 MHz clock available on MCLK2 pin. > > + type: boolean > > This should be clock-cells and clock provider. > > Unless you are just documenting already used interface which you do not > want to break... > > > + > > bipolar: > > description: see Documentation/devicetree/bindings/iio/adc/adc.yaml > > type: boolean > > Best regards, > Krzysztof >
