These variables need to be int for the error handling to work. Fixes: f053d4e748ce ("iio: light: Added AMS tsl2591 driver implementation") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/iio/light/tsl2591.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/tsl2591.c b/drivers/iio/light/tsl2591.c index 2bdae388ff01..26e3cb6c4ff8 100644 --- a/drivers/iio/light/tsl2591.c +++ b/drivers/iio/light/tsl2591.c @@ -213,7 +213,7 @@ static int tsl2591_gain_to_multiplier(const u8 als_gain) } } -static u8 tsl2591_multiplier_to_gain(const u32 multiplier) +static int tsl2591_multiplier_to_gain(const u32 multiplier) { switch (multiplier) { case TSL2591_CTRL_ALS_LOW_GAIN_MULTIPLIER: @@ -783,8 +783,8 @@ static int tsl2591_write_raw(struct iio_dev *indio_dev, int val, int val2, long mask) { struct tsl2591_chip *chip = iio_priv(indio_dev); - u32 int_time; - u8 gain; + int int_time; + int gain; int ret; mutex_lock(&chip->als_mutex); -- 2.30.2