Re: [PATCH 15/28] iio: adc: stm32-dfsdm: Use pm_runtime_resume_and_get() to replace open coding.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 May 2021 15:31:33 +0200
Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx> wrote:

> On 5/9/21 1:33 PM, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > 
> > Found using coccicheck script under review at:
> > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@xxxxxxxx/
> > 
> > This is a prequel to taking a closer look at the runtime pm in IIO drivers
> > in general.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > Cc: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> > ---
> >  drivers/iio/adc/stm32-dfsdm-core.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)  
> 
> 
> Hi Jonathan,
> 
> Reviewed-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
Applied, thanks

> 
> Thanks for the patch,
> Regards,
> Fabrice
> 
> > 
> > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> > index bb925a11c8ae..a627af9a825e 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-core.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> > @@ -135,11 +135,9 @@ int stm32_dfsdm_start_dfsdm(struct stm32_dfsdm *dfsdm)
> >  	int ret;
> >  
> >  	if (atomic_inc_return(&priv->n_active_ch) == 1) {
> > -		ret = pm_runtime_get_sync(dev);
> > -		if (ret < 0) {
> > -			pm_runtime_put_noidle(dev);
> > +		ret = pm_runtime_resume_and_get(dev);
> > +		if (ret < 0)
> >  			goto error_ret;
> > -		}
> >  
> >  		/* select clock source, e.g. 0 for "dfsdm" or 1 for "audio" */
> >  		clk_src = priv->aclk ? 1 : 0;
> >   




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux