On Tue, 4 May 2021 18:41:02 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, May 4, 2021 at 6:37 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> >
> > With CONFIG_ACPI=n and -Werror, 0-day reports:
> >
> > drivers/iio/humidity/am2315.c:259:36: error:
> > 'am2315_acpi_id' defined but not used
> >
> > According to Andy Shevchenko, the ACPI ID used in this driver is fake
> > and does not really exist. Remove it and with it ACPI support from
> > the driver.
>
> As I have found zarro evidences, I agree with removal. We must not
> create fake ACPI IDs on our owns. If anybody will find a device that
> is using this broken ID for real, then we may add it back.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Applied to the togreg branch of iio.git with the commit message changed to
reflect PRP0001 still working with this gone.
Thanks,
Jonathan
>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > v2: Instead of making am2315_acpi_id depend on CONFIG_ACPI,
> > remove ACPI support entirely.
> >
> > drivers/iio/humidity/am2315.c | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> > index 23bc9c784ef4..8d7ec2f5acf8 100644
> > --- a/drivers/iio/humidity/am2315.c
> > +++ b/drivers/iio/humidity/am2315.c
> > @@ -7,7 +7,6 @@
> > * 7-bit I2C address: 0x5C.
> > */
> >
> > -#include <linux/acpi.h>
> > #include <linux/delay.h>
> > #include <linux/i2c.h>
> > #include <linux/kernel.h>
> > @@ -256,17 +255,9 @@ static const struct i2c_device_id am2315_i2c_id[] = {
> > };
> > MODULE_DEVICE_TABLE(i2c, am2315_i2c_id);
> >
> > -static const struct acpi_device_id am2315_acpi_id[] = {
> > - {"AOS2315", 0},
> > - {}
> > -};
> > -
> > -MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> > -
> > static struct i2c_driver am2315_driver = {
> > .driver = {
> > .name = "am2315",
> > - .acpi_match_table = ACPI_PTR(am2315_acpi_id),
> > },
> > .probe = am2315_probe,
> > .id_table = am2315_i2c_id,
> > --
> > 2.25.1
> >
>
>
