Re: [PATCH 05/11] iio: chemical: atlas: Fix buffer alignment in iio_push_to_buffers_with_timestamp()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 1, 2021 at 10:15 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> Variable location for the timestamp, so just use __aligned(8)
> to ensure it is always possible to naturally align it.
>
> Found during an audit of all calls of uses of
> iio_push_to_buffers_with_timestamp()
>
> Fixes tag is not accurate, but it will need manual backporting beyond
> that point if anyone cares.
>
> Fixes: 0d15190f53b4 ("iio: chemical: atlas-ph-sensor: rename atlas-ph-sensor to atlas-sensor")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Acked-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx>

> Cc: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx>
> ---
>  drivers/iio/chemical/atlas-sensor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
> index 56ba6c82b501..6795722c68b2 100644
> --- a/drivers/iio/chemical/atlas-sensor.c
> +++ b/drivers/iio/chemical/atlas-sensor.c
> @@ -91,8 +91,8 @@ struct atlas_data {
>         struct regmap *regmap;
>         struct irq_work work;
>         unsigned int interrupt_enabled;
> -
> -       __be32 buffer[6]; /* 96-bit data + 32-bit pad + 64-bit timestamp */
> +       /* 96-bit data + 32-bit pad + 64-bit timestamp */
> +       __be32 buffer[6] __aligned(8);
>  };
>
>  static const struct regmap_config atlas_regmap_config = {
> --
> 2.31.1
>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux