With CONFIG_ACPI=n, W=1 and -Werror, 0-day reports: drivers/iio/accel/stk8312.c:644:36: error: 'stk8312_acpi_id' defined but not used Apparently STK8312 is not a valid ACPI ID. Remove it and with it ACPI support from the stk8312 driver. Reported-by: kernel test robot <lkp@xxxxxxxxx> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Cc: Hans de Goede <hdegoede@xxxxxxxxxx> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> --- There is another patch pending which makes whitespace changes in struct acpi_device_id stk8312_acpi_id. This will result in a conflict if this patch is applied. In that patch, it is claimed that the driver would possibly only be used based on its ACPI ID (even though that ACPI device ID is not official). Link: https://patchwork.kernel.org/project/linux-iio/patch/20210401144226.225928-1-jic23@xxxxxxxxxx/ I can not determine if that claim has any truth in it. Still, it appears that the device ID is not an official device ID. drivers/iio/accel/stk8312.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c index 157d8faefb9e..2fc30cfe1457 100644 --- a/drivers/iio/accel/stk8312.c +++ b/drivers/iio/accel/stk8312.c @@ -7,7 +7,6 @@ * IIO driver for STK8312; 7-bit I2C address: 0x3D. */ -#include <linux/acpi.h> #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/kernel.h> @@ -640,18 +639,10 @@ static const struct i2c_device_id stk8312_i2c_id[] = { }; MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id); -static const struct acpi_device_id stk8312_acpi_id[] = { - {"STK8312", 0}, - {} -}; - -MODULE_DEVICE_TABLE(acpi, stk8312_acpi_id); - static struct i2c_driver stk8312_driver = { .driver = { .name = STK8312_DRIVER_NAME, .pm = STK8312_PM_OPS, - .acpi_match_table = ACPI_PTR(stk8312_acpi_id), }, .probe = stk8312_probe, .remove = stk8312_remove, -- 2.25.1
