Re: [RFC PATCH 2/4] iio: accel: fxls8962af: add interrupt support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 29, 2021 at 11:58 AM Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> On 4/28/21 10:22 AM, Sean Nyekjaer wrote:
> > Preparation commit for the next that adds hw buffered sampling

...

> > +     irq = of_irq_get_byname(of_node, "INT2");
>
> For this I'd use device_property_match_string(dev, "interrupt-names",
> "INT2"). Means it won't try to map the interrupt again, and also this is
> the only place where the driver directly depends on OF, everything else
> already uses the device_ API.

Why not platform_get_irq_byname_optional() ?

> > +     if (irq > 0) {
> > +             *pin = FXLS8962AF_PIN_INT2;
> > +             return;
> > +     }

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux