Hi Dmitry, probably this mail passed under your radar. Can you please add your statement here. On Mon, Mar 29, 2021 at 11:58:26AM +0100, Jonathan Cameron wrote: > On Mon, 29 Mar 2021 09:31:31 +0200 > Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for > > the touchscreen use case. By implementing it as an IIO ADC device, we can > > make use of resistive-adc-touch and iio-hwmon drivers. > > > > Polled readings are currently not implemented to keep this patch small, so > > iio-hwmon will not work out of the box for now. > > > > So far, this driver was tested with a custom version of resistive-adc-touch driver, > > since it needs to be extended to make use of Z1 and Z2 channels. The X/Y > > are working without additional changes. > > > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Hi Oleksij, > > Couple of things in here I missed before, but big question is still whether > Dmitry is happy with what you mention in the cover letter: > > "This driver can replace drivers/input/touchscreen/ads7846.c and has > following advantages over it: > - less code to maintain > - shared code paths (resistive-adc-touch, iio-hwmon, etc) > - can be used as plain IIO ADC to investigate signaling issues or test > real capacity of the plates and attached low-pass filters > (or use the touchscreen as a microphone if you like ;) )" > > So two things that need addressing in here are > iio_dev->name (part number, not hybrid of that an spi device name) > Why oversampling is DT rather than userspace controllable. > For that I'm looking for clear reasoning for the choice. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
