On Fri, 2 Apr 2021 10:35:17 +0200 Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: > On 4/1/21 7:17 PM, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Not all of the parts supported by this driver use single supply. > > Hence we add chip_info fields to say what additional supplies exist > > and in the case of vref, ensure that is used for the reference voltage > > rather than vcc. > > > > Tested using really simple QEMU model and some fixed regulators. > > > > The devm_add_action_or_reset() callback is changed to take the > > regulator as it's parameter so we can use one callback for all the > > different regulators without having to store pointers to them in > > the iio_priv() structure. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Cc: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > Looks good. > > Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > > There is one special case that is currently not handled. The AD7091R can > either use its internal reference, or an external reference. > > At the moment the driver sets neither has_vref nor int_vref_uv. Ah. I'd missed that one. Let's fix that whilst we are here. Enough stuff will change in V2 that I'll not keep that Reviewed-by tag. Thanks, Jonathan
