RE: [PATCH 1/4] iio: adis: add helpers for locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Sunday, January 24, 2021 2:30 PM
> To: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; Rob
> Herring <robh+dt@xxxxxxxxxx>; Peter Meerwald-Stadler
> <pmeerw@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>;
> Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Ardelean,
> Alexandru <alexandru.Ardelean@xxxxxxxxxx>
> Subject: Re: [PATCH 1/4] iio: adis: add helpers for locking
> 
> 
> On Thu, 21 Jan 2021 12:49:51 +0100
> Nuno Sá <nuno.sa@xxxxxxxxxx> wrote:
> 
> > Add some helpers to lock and unlock the device.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> 
> Hi Nuno
>

Hi Jonathan,

> For a patch like this I'd also expect to see it immediately used in
> all relevant places in the driver. I don't want a mixture
> going forwards of this vs direct access to the lock.

Fully agreed...

> No need to separate that into two patches for such a simple case
> just introduce this and put it to use.  There aren't that
> many call sites anyway from a quick grep.
> 

Ok, will do that in v2.

- Nuno Sá







[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux