On Wed, Dec 16, 2020 at 8:02 AM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > > Use dev = &device->dev in probe routine for clarity. > Remove setting parent of iio device, already done in iio_device_alloc(). ... > struct acpi_als *als; > struct iio_dev *indio_dev; > struct iio_buffer *buffer; > + struct device *dev = &device->dev; Try to keep reversed xmas tree order. -- With Best Regards, Andy Shevchenko