Hi Jonathan, On Sun, Sep 20, 2020 at 3:54 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > This binding is non trivial due to the range of different parts > supported having several subtle quirks. Martin has helped > clarify some of them. > > Note, I haven't restricted the amlogic,hhi-sysctrl to only > be present on the relevant parts if nvmem stuff also is, but > it would seem to be rather odd if it were otherwise. > > Perhaps we look to make this binding more restrictive at a later date. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> this is looking great - so in case it's not too late please add my: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> Best regards, Martin