On Tue, 22 Sep 2020 13:40:12 -0500 Michael Auchter <michael.auchter@xxxxxx> wrote: > Add a binding for AD5686 > > Signed-off-by: Michael Auchter <michael.auchter@xxxxxx> Hi Michael, Thanks for this. A few comments inline. Thanks, Jonathan > --- > Changes since v1: > - Keep supported device sorted > - fix adc -> dac type in schema path > > .../bindings/iio/dac/adi,ad5686.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > new file mode 100644 > index 000000000000..9ce76d75f31b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD5686 and similar multi-channel DACs > + > +maintainers: > + - Michael Auchter <michael.auchter@xxxxxx> > + > +description: | > + Binding for Analog Devices AD5686 and similar multi-channel DACs > + > +properties: > + compatible: > + enum: > + - adi,ad5311r > + - adi,ad5338r > + - adi,ad5671r > + - adi,ad5675r > + - adi,ad5691r > + - adi,ad5692r > + - adi,ad5693 > + - adi,ad5693r > + - adi,ad5694 > + - adi,ad5694r > + - adi,ad5695r > + - adi,ad5696 > + - adi,ad5696r > + > + reg: > + maxItems: 1 > + > + vcc-supply: > + description: | > + The regulator supply for DAC reference voltage. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 Why address-cells and size-cells? Properties we are giving are for the dac, not the i2c bus. > + > +required: > + - compatible > + - reg additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ad5686: dac@0 { > + compatible = "adi,ad5686"; > + reg = <0>; > + vcc-supply = <&dac_vref>; > + }; > + }; > +
