On Wed, 09 Sep 2020 17:42:40 +0300, Dmitry Baryshkov wrote: > Add bindings for thermal monitor, part of Qualcomm PMIC5 chips. It is a > close counterpart of VADC part of those PMICs. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 141 ++++++++++++++++++ > 1 file changed, 141 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:25.17-30: Warning (reg_format): /example-0/adc@3100/conn-therm@4f:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:33.13-28: Warning (reg_format): /example-0/adc-tm@3500:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:21.31-29.11: Warning (unit_address_vs_reg): /example-0/adc@3100: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:24.27-28.15: Warning (avoid_default_addr_size): /example-0/adc@3100/conn-therm@4f: Relying on default #address-cells value Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:24.27-28.15: Warning (avoid_default_addr_size): /example-0/adc@3100/conn-therm@4f: Relying on default #size-cells value Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size' Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:39.26-45.15: Warning (io_channels_property): /example-0/adc-tm@3500/conn-therm@0: Missing property '#io-channel-cells' in node /example-0/adc@3100 or bad phandle (referred from io-channels[0]) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: example-0: adc-tm@3500:reg:0: [13568] is too short From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: 'reg' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: '#address-cells' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: '#size-cells' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: '#io-channel-cells' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml See https://patchwork.ozlabs.org/patch/1360722 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
