On Mon, 31 Aug 2020 15:12:01 +0100 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Mon, 31 Aug 2020 14:49:04 +0300 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > On Mon, Aug 31, 2020 at 10:21:45AM +0100, Jonathan Cameron wrote: > > > On Mon, 31 Aug 2020 12:08:06 +0300 > > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > > > > Potentially bma220_init() and bma220_deinit() may return positive codes. > > > > Fix the logic to return proper error codes instead. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > Hi Andy > > > > > > A nice straight forward set and I suspect we aren't going to get any other > > > reviews, hence... > > > > > > Series applied to the togreg branch of iio.git and pushed out as testing for > > > the autobuilders to poke at it. > > > > Thanks! > > > > P.S. Consider this series as an example what can be done to many IIO drivers > > in order to clean them up. My focus, of course, ACPI interaction: > > - use of ACPI_PTR / ifdeffery > > - inclusion of acpi.h > > - ... > > > > Thanks. This is probably a good one for anyone who wants to grow their > experience in kernel patches etc. I'll add it to my more or less > never ending list if not and get to it eventually. > > In the meantime we'll try to avoid introducing any new variants! > > Jonathan Andy, one thing that might want adjusting is the docs that suggest doing ACPI_PTR and ifdeffery. https://elixir.bootlin.com/linux/v5.9-rc3/source/Documentation/firmware-guide/acpi/enumeration.rst#L254 J
